[LLVMGPU] Preserve swizzle attributes through pipelining#24002
Draft
Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Draft
[LLVMGPU] Preserve swizzle attributes through pipelining#24002Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Conversation
Yu-Zhewen
requested review from
Groverkss,
MaheshRavishankar,
Max191,
hanhanW,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
Part 3/3 of enabling XOR swizzle with software pipelining (iree-org#23919). Wires AbsorbSwizzleHintToAllocPass before and ReinsertSwizzleHintsPass after ROCDLPrefetchSharedMemoryPass, and preserves the iree_codegen.swizzle attribute through memref::multiBuffer. Fixes: iree-org#23919 Assisted-by: Cursor (Claude) Signed-off-by: Yu-Zhewen <zhewenyu@amd.com> Made-with: Cursor
Yu-Zhewen
force-pushed
the
pipeliner-swizzle-hint-3
branch
from
6388faa to
61faf0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/3 of enabling XOR swizzle with software pipelining (#23919).
Overall plan:
SwizzleHintOpin the SSA chain blocks bothmemref::multiBufferandscf::pipelineForLoop. The fix absorbs the hint into an alloc attribute before pipelining, preserves it through multi-buffering, then re-inserts hints at leaf users afterward.This PR: Wires
AbsorbSwizzleHintToAllocPassbefore andReinsertSwizzleHintsPassafterROCDLPrefetchSharedMemoryPass, and preserves theiree_codegen.swizzleattribute throughmemref::multiBuffer.Fixes: #23919
Assisted-by: Cursor (Claude)