[Codegen] Handle SwizzleHintOp in shared memory pipeliner#23945
Draft
Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Draft
[Codegen] Handle SwizzleHintOp in shared memory pipeliner#23945Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Yu-Zhewen wants to merge 1 commit intoiree-org:mainfrom
Conversation
Yu-Zhewen
force-pushed
the
pipeliner-swizzle-hint
branch
from
6370ab4 to
7a56bc8
Compare
Signed-off-by: Yu-Zhewen <zhewenyu@amd.com> Made-with: Cursor
Yu-Zhewen
force-pushed
the
pipeliner-swizzle-hint
branch
from
7a56bc8 to
35de084
Compare
Yu-Zhewen
requested review from
Groverkss,
Max191,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
lialan
reviewed
Mar 27, 2026
| @@ -289,7 +399,7 @@ static LogicalResult multiBufferLDSAllocations(scf::ForOp forOp, | |||
|
|
|||
| // First, clone view ops inside the loop for each allocation | |||
Contributor
Author
|
After discussing with @jerryyin, we feel the current approach is quite brittle. I'm going to explore alternative options. One possibility is to have Converting back to draft while I investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23919
Assisted-by: Cursor (Claude)