Skip to content

fix: align attention_mask padding with appended eos token in clvp #45757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlieKerfoot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: align attention_mask padding with appended eos token in clvp #45757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/clvp/modeling_clvp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _pad_extra_bos_eos_tokens(
# if there are no pad tokens present, then add eos to the end
modified_input_ids[i] = torch.nn.functional.pad(each_input_id, (0, 1), value=eos_token_id)
attention_mask = (
torch.nn.functional.pad(attention_mask, (1, 0), value=1) if attention_mask is not None else attention_mask
torch.nn.functional.pad(attention_mask, (0, 1), value=1) if attention_mask is not None else attention_mask
)

return modified_input_ids, attention_mask
Expand Down
Loading