fix: align attention_mask padding with appended eos token in clvp#45757
Open
CharlieKerfoot wants to merge 1 commit intohuggingface:mainfrom
Open
fix: align attention_mask padding with appended eos token in clvp#45757CharlieKerfoot wants to merge 1 commit intohuggingface:mainfrom
CharlieKerfoot wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: clvp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
_pad_extra_bos_eos_tokensatsrc/transformers/models/clvp/modeling_clvp.py:144, whenadd_eos_token=Truethe eos token is appended to the right ofinput_idsbutattention_maskwas padded on the left. The mask no longer lines up with the tokens, so the appended eos position gets the wrong mask value and a real token at position 0 is masked out.Fix
Pad
attention_maskon the right(0, 1)instead of the left(1, 0)so the new mask entry corresponds to the appended eos token.