fix(i18n): standardize UI-language promise on 12 premium + close the stale gate#226
Merged
Conversation
…stale gate The "in-product UI localized in 11 languages" claim was a stale conflation of three separate surfaces. Standardized on 12 (premium dictionaries) per owner decision, and fixed the root cause: a hardcoded CI gate that let two real gaps through. - Gate (scripts/check-i18n-keys.js): `expectedLangs` was a hand-coded `en + 10` list (missing it, id), so `check:i18n` passed at 0 warnings while it/id labels were actually missing. Now derived from `PREMIUM_LANGUAGE_CODES` (en + 12), self-updating when a premium locale is added, with a 12-language fallback. - Labels (src/lib/constants.js): filled the gaps the tightened gate surfaced — BANNER_UI.it, BANNER_UI.id, EXAMPLE_QUESTIONS.id — so the gate matches the actual product promise. Native-reviewed (it + id). check:i18n is back to 0 warnings. - Docs: "11 languages" → "12 premium languages" (POSITIONING ×2, TODO, TELEMETRY), and separated the 33 `_locales/` Chrome-metadata locales from the in-product UI promise and the EN-only store-listing copy, which were being conflated. The three surfaces, now stated distinctly: premium dictionaries + in-product UI labels = 12; `_locales/` browser name/description metadata = 33; CWS listing marketing copy = EN-only. 9 gates green (check:i18n 0/0) · 555 unit · e2e 20/20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "in-product UI localized in 11 languages" claim was a stale conflation of three separate surfaces. Standardized on 12 (premium dictionaries) per owner decision, and fixed the root cause: a hardcoded CI gate that let two real gaps through.
Gate (
scripts/check-i18n-keys.js)expectedLangswas a hand-codeden + 10list (missingit,id), socheck:i18npassed at 0 warnings while the it/id UI labels were actually missing. Now derived fromPREMIUM_LANGUAGE_CODES(en + 12) — self-updating when a premium locale is added, with a 12-language fallback. Tightening it immediately surfaced exactly the two gaps below.Labels (
src/lib/constants.js)Filled what the tightened gate surfaced —
BANNER_UI.it,BANNER_UI.id,EXAMPLE_QUESTIONS.id— so the gate matches the real product promise. Native-reviewed (it + id).check:i18nback to 0 warnings.Docs
11 languages→12 premium languages(POSITIONING ×2, TODO, TELEMETRY_DESIGN), and separated the three surfaces that were being conflated:_locales/browser name/description (Chrome metadata)Verify
9 gates green (check:i18n 0/0) · 555 unit · e2e 20/20.
🤖 Generated with Claude Code