Skip to content

Refactor strip-layout and place strips on all four sides #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
has2k1 merged 13 commits into from
Jun 26, 2026
Merged

Refactor strip-layout and place strips on all four sides #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ce81294
refactor(strip): drop dead patch.position attribute and stale comment
has2k1 Jun 25, 2026
e48556b
refactor(layout): name side-space axis parts without the x/y suffix
has2k1 Jun 25, 2026
0a2f277
refactor(layout): name the side-space strip part after the artist
has2k1 Jun 25, 2026
f159611
feat(strip): per-side strip_text themeables, targets, and per-side ar…
has2k1 Jun 25, 2026
3f539bc
refactor(layout): unify strip placement behind StripSpec
has2k1 Jun 25, 2026
ae24c9d
feat(layout): place strips on the bottom and left sides
has2k1 Jun 25, 2026
48a5d66
refactor(layout): strip part declares its default (inside) placement
has2k1 Jun 25, 2026
9ebdeb5
docs(layout): document the strip/axis band ordering
has2k1 Jun 25, 2026
378f48e
test(layout): pin the spine-outward private-API contract
has2k1 Jun 25, 2026
eb9a84d
refactor(layout): drop the legacy axis_title_x/_y target bridge
has2k1 Jun 25, 2026
56d8dd6
refactor(layout): name positioning helpers _position_*
has2k1 Jun 25, 2026
6e6fbbb
docs(layout): results-oriented docstrings for StripSpec helpers
has2k1 Jun 25, 2026
7ee839e
feat(theme): accept per-side strip_text themeable kwargs
has2k1 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions doc/_quartodoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,18 @@ quartodoc:
- aspect_ratio
- axis_line
- axis_line_x
- axis_line_x_bottom
- axis_line_x_top
- axis_line_y
- axis_line_y_left
- axis_line_y_right
- axis_text
- axis_text_x
- axis_text_x_bottom
- axis_text_x_top
- axis_text_y
- axis_text_y_left
- axis_text_y_right
- axis_ticks
- axis_ticks_length
- axis_ticks_length_major
Expand All @@ -416,15 +424,27 @@ quartodoc:
- axis_ticks_length_minor_y
- axis_ticks_major
- axis_ticks_major_x
- axis_ticks_major_x_bottom
- axis_ticks_major_x_top
- axis_ticks_major_y
- axis_ticks_major_y_left
- axis_ticks_major_y_right
- axis_ticks_minor
- axis_ticks_minor_x
- axis_ticks_minor_x_bottom
- axis_ticks_minor_x_top
- axis_ticks_minor_y
- axis_ticks_minor_y_left
- axis_ticks_minor_y_right
- axis_ticks_x
- axis_ticks_y
- axis_title
- axis_title_x
- axis_title_x_bottom
- axis_title_x_top
- axis_title_y
- axis_title_y_left
- axis_title_y_right
- dpi
- figure_size
- legend_background
Expand Down Expand Up @@ -499,9 +519,14 @@ quartodoc:
- strip_background
- strip_background_x
- strip_background_y
- strip_placement
- strip_text
- strip_text_x
- strip_text_x_bottom
- strip_text_x_top
- strip_text_y
- strip_text_y_left
- strip_text_y_right
- svg_usefonts
- text
- title
Expand Down
4 changes: 2 additions & 2 deletions plotnine/_mpl/layout_manager/_composition_layout_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def _move_artists(self, spaces: CompositionSideSpaces):
Move the annotations and legends to their final positions
"""
from ._plot_layout_items import (
_position_legends,
_position_plot_labels,
set_legends_position,
)

# Only the root composition can have annotations (labels).
Expand All @@ -69,4 +69,4 @@ def _move_artists(self, spaces: CompositionSideSpaces):
spaces.cmp.figure, self.cmp.theme, spaces, self
)
if self.legends:
set_legends_position(self.legends, spaces)
_position_legends(self.legends, spaces)
Loading
Loading