Refactor strip-layout and place strips on all four sides#1090
Merged
Conversation
Add strip_text_x_top/_bottom and strip_text_y_left/_right as theme() keyword arguments so the per-side strip_text themeables can be set directly (their classes and targets already existed). Also list the per-side themeables (axis line/text/ticks/title sides, strip_placement, and per-side strip_text) in the quartodoc API reference.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 87.28% 87.29% +0.01%
==========================================
Files 208 208
Lines 14569 14609 +40
Branches 1824 1825 +1
==========================================
+ Hits 12716 12753 +37
- Misses 1281 1283 +2
- Partials 572 573 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the strip-layout code (now that
strip_placementhas landed) and extends the layout manager to place strips on all four sides. Behaviour-preserving, the existing top/right rendering is unchanged.