refactor: introduce generation run state model#652
Merged
jayscambler merged 2 commits intorefactor/internal-barrel-reductionfrom Apr 9, 2026
Merged
Conversation
fe4ecf3
into
refactor/internal-barrel-reduction
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerationRunnerTDD / DDD / DRY framing
This is the next stacked architectural PR after #651.
Bounded context extracted:
Test-first work:
GenerationRunnerto use the extracted state modelChanges
New module
ts/src/loop/generation-run-state.tscreateGenerationRunStaterecordGenerationResultqueueFreshStartHintconsumeFreshStartHintcompleteGenerationRunfailGenerationRunNew tests
ts/tests/generation-run-state.test.tsRunner integration
ts/src/loop/generation-runner.tsValidation
cd ts && npx vitest run tests/generation-run-state.test.ts tests/generation-loop.test.ts tests/generation-journal.test.ts tests/generation-recovery.test.ts tests/generation-runner-prompts.test.tscd ts && npm run lintWhy this matters
This does not introduce XState yet. It is the intermediate step that isolates the generation-loop lifecycle as a state model first, so a future state-machine PR can be evaluated on top of an explicit transition surface instead of a giant mutable class.