refactor: extract mission lifecycle transitions#653
Merged
jayscambler merged 1 commit intorefactor/generation-run-state-modelfrom Apr 9, 2026
Merged
Conversation
80e81bc
into
refactor/generation-run-state-model
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MissionManagerTDD / DDD / DRY framing
This is the next stacked architectural PR after #652.
Bounded context extracted:
Test-first work:
MissionManagerto delegate transition and verifier-error/result mappingChanges
New module
ts/src/mission/lifecycle.tsresolveMissionStatusTransitionderiveMissionStatusFromVerifierResultbuildVerifierErrorResultNew tests
ts/tests/mission-lifecycle.test.tsManager integration
ts/src/mission/manager.tsValidation
cd ts && npx vitest run tests/mission-lifecycle.test.ts tests/mission.test.ts tests/mission-execution.test.ts tests/mission-dashboard.test.tscd ts && npm run lintFollow-up
At this point, the main remaining code-review recommendation is the larger codegen templating redesign (moving more generator logic away from giant inline strings toward template-backed generation). A future XState-style rewrite can build on the explicit generation and mission state/lifecycle modules introduced in this stack.