Fix rake task helpers polluting global namespace

[hibachrach]

Before, the session method (for example) would be redefined in the
context of an RSpec request spec because the default definee in the
block within the namespace call would be main, the global object.

Additional context about default definees:
https://blog.yugui.jp/entry/846

[jasonkarns]

Another option is to define the methods in an external file/module, and only require them from within the task defs. That way they're only included when those tasks are actually run.

[hibachrach]

Would you prefer that option? Willing to edit the PR if that's the case.

[jasonkarns]

@hibachrach I'm not one of the maintainers, so I can't speak for them or the project. However, moving the module(s) into an external file that is explicitly (and only) required when needed is the approach I use and recommend on my teams. As it stands in this PR, the Graphiti::Rails::RakeHelpers modules are all being defined whether those tasks are invoked or not. (The namespace body is evaluated when rake loads the file, as that is how rake knows what tasks exist.)

What's more, then you can include Graphiti::Rails::RakeHelpers in the task body and use the methods inline (unqualified) as they were before.

[jkeen]

^ I agree with @jasonkarns

[jkeen]

This is fixed in graphiti 2.0. graphiti-rails is merged into the 2.0 gem, so the rake tasks live at https://github.com/graphiti-api/graphiti/blob/beta/lib/tasks/graphiti.rake.

Your commit is now in a different repo: graphiti-api/graphiti@0a41a60. I took @jasonkarns' suggestion from this thread and moved the helpers into their own file rather than defining them inside the namespace block.