fix: keep rake task helpers out of the global namespace

Ported from graphiti-api/graphiti-rails#91, following the review there: the helpers move to their own file rather than being defined inside the rake namespace.

Author: hibachrach

lib/graphiti/rails/rake_helpers.rb

@@ -0,0 +1,42 @@
+require "graphiti/rails/test_helpers"
+
+module Graphiti
+  module Rails
+    # Rake's `namespace` takes a block, and a block does not open a new definee,
+    # so helpers defined inside one are defined on Object and turn up in every
+    # request spec in the host app. They live here to stay off that namespace.
+    module RakeHelpers
+      extend TestHelpers
+
+      module_function
+
+      # ::Rails throughout, because bare Rails resolves to Graphiti::Rails here.
+      def session
+        @session ||= ActionDispatch::Integration::Session.new(::Rails.application)
+      end
+
+      def setup_rails!
+        ::Rails.application.eager_load!
+        ::Rails.application.config.cache_classes = true
+        ::Rails.application.config.action_controller.perform_caching = false
+      end
+
+      def make_request(path, debug = false)
+        if path.split("/").length == 2
+          path = "#{ApplicationResource.endpoint_namespace}#{path}"
+        end
+        path << if path.include?("?")
+          "&cache=bust"
+        else
+          "?cache=bust"
+        end
+        path = "#{path}&debug=true" if debug
+        handle_request_exceptions do
+          headers = {Authorization: ENV["AUTHORIZATION_HEADER"]}.compact
+          session.get(path.to_s, headers: headers)
+        end
+        JSON.parse(session.response.body)
+      end
+    end
+  end
+end

lib/tasks/graphiti.rake

@@ -1,52 +1,27 @@
-namespace :graphiti do
-  include Graphiti::Rails::TestHelpers
-
-  def session
-    @session ||= ActionDispatch::Integration::Session.new(Rails.application)
-  end
+require "graphiti/rails/rake_helpers"
 
-  def setup_rails!
-    Rails.application.eager_load!
-    Rails.application.config.cache_classes = true
-    Rails.application.config.action_controller.perform_caching = false
-  end
-
-  def make_request(path, debug = false)
-    if path.split("/").length == 2
-      path = "#{ApplicationResource.endpoint_namespace}#{path}"
-    end
-    path << if path.include?("?")
-      "&cache=bust"
-    else
-      "?cache=bust"
-    end
-    path = "#{path}&debug=true" if debug
-    handle_request_exceptions do
-      headers = {Authorization: ENV["AUTHORIZATION_HEADER"]}.compact
-      session.get(path.to_s, headers: headers)
-    end
-    JSON.parse(session.response.body)
-  end
+namespace :graphiti do
+  helpers = Graphiti::Rails::RakeHelpers
 
   desc "Execute request without web server."
   task :request, [:path, :debug] => [:environment] do |_, args|
-    setup_rails!
+    helpers.setup_rails!
     Graphiti.logger = Graphiti.stdout_logger
     Graphiti::Debugger.preserve = true
     require "pp"
     path, debug = args[:path], args[:debug]
     puts "Graphiti Request: #{path}"
-    json = make_request(path, debug)
+    json = helpers.make_request(path, debug)
     pp json
     Graphiti::Debugger.flush if debug
   end
 
   desc "Execute benchmark without web server."
   task :benchmark, [:path, :requests] => [:environment] do |_, args|
-    setup_rails!
+    helpers.setup_rails!
     took = Benchmark.ms {
       args[:requests].to_i.times do
-        make_request(args[:path])
+        helpers.make_request(args[:path])
       end
     }
     puts "Took: #{(took / args[:requests].to_f).round(2)}ms"