Initial stab at moving benchmark logic to python.#1301
Draft
erikfrey wants to merge 2 commits intogoogle-deepmind:mainfrom
Draft
Initial stab at moving benchmark logic to python.#1301erikfrey wants to merge 2 commits intogoogle-deepmind:mainfrom
erikfrey wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
Cleans up testspeed to be only human readable output. Moves benchmark running to benchmarks/run.py with example in humanoid.
thowell
reviewed
Apr 20, 2026
| @@ -0,0 +1,16 @@ | |||
| BENCHMARKS = [ | |||
Collaborator
There was a problem hiding this comment.
is the plan to add an __init__.py file for every directory in benchmarks?
Collaborator
Author
There was a problem hiding this comment.
Yes! I'm going to do aloha next because I want to add asset fetching next to this approach.
thowell
reviewed
Apr 20, 2026
| "mjcf": "humanoid.xml", | ||
| "nworld": 8192, | ||
| "nconmax": 24, | ||
| "njmax": 72, |
Collaborator
There was a problem hiding this comment.
is it intential to change the value of this parameter?
mujoco_warp/benchmarks/config.txt
Line 21 in fcfaeef
Collaborator
Author
There was a problem hiding this comment.
I was getting overflow warnings, weirdly. I'll reconcile whether something changed at HEAD or whether I broke something (and then fix it) as part of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up testspeed to be only human readable output. Moves benchmark running to benchmarks/run.py with example in humanoid.