Skip to content

MODLOGSAML-162: Make MaximumAuthenticationLifetime configurable (SSO)#213

Open
TrentTAMU wants to merge 4 commits intofolio-org:masterfrom
TAMULib:master
Open

MODLOGSAML-162: Make MaximumAuthenticationLifetime configurable (SSO)#213
TrentTAMU wants to merge 4 commits intofolio-org:masterfrom
TAMULib:master

Conversation

@TrentTAMU
Copy link
Copy Markdown

https://folio-org.atlassian.net/browse/MODLOGSAML-162

  • Adds the environment variable MAX_AUTH_LIFETIME to allows orgs to define what the max authentication lifetime of an IdP session should be. Units are seconds and default value is '28800' (8 hours).
  • Added error handling when casting String to Integer

Allows organizations to configure an arbitrary time limit. Default value is 28800 seconds (8 hours).
Adds the environment variable MAX_AUTH_LIFETIME to allows orgs to define what the max authentication lifetime of an IdP session should be. Units are seconds and default value is '28800' (8 hours).
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 5, 2026

CLA assistant check
All committers have signed the CLA.

@TrentTAMU TrentTAMU marked this pull request as draft March 5, 2026 20:22
MAX_AUTH_LIFETIME_SEC -> maxAuthLifetimeSec
@ArgonV ArgonV requested a review from julianladisch March 5, 2026 20:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
52.9% Coverage on New Code (required ≥ 80%)
96.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

https://folio-org.atlassian.net/browse/MODLOGSAML-162 requests a configuration option on tenant settings level. Currently this PR doesn't work on tenant level, if the value is changed for one tenant it is changed for all tenants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants