MODLOGSAML-219: Support MAX_AUTH_LIFETIME env var configuration

[julianladisch]

https://folio-org.atlassian.net/browse/MODLOGSAML-219

Support the MAX_AUTH_LIFETIME environment variable to configure the maximum authentication lifetime in seconds. This configuration applies to all tenants.

(For a per tenant based configuration see https://folio-org.atlassian.net/browse/MODLOGSAML-162 )

(mod-login-saml is a Okapi-only module that gets replaced with Keycloak in Eureka based FOLIO installations.)

[barbaraloehle]

There are questions concerning the formulation of the method

public static void setMaximumAuthenticationLifetime(String seconds)

What is the reason for not treating the possible NumberFormatException in an explicit manner?

try {
...
} catch (NumberFormatException numEx) {
  throw new NumberFormatException("Bad environmental variable value of
  "MAX_AUTH_LIFETIME" + seconds + ": " + numEx.getMessage());
}

If it is not necessary to throw a NumberFormatException
the default value DEFAULT_MAXIMUM_AUTHENTICATION_LIFETIME could be used.
(compare the suggestion of the Pull Request #213)

try {
...
} catch (NumberFormatException numEx) {
  logger.warn("Bad environmental variable value of MAX_AUTH_LIFETIME: {}. Replaced by the default value : {}}", seconds, numEx.getMessage(), DEFAULT_MAXIMUM_AUTHENTICATION_LIFETIME));
  maximumAuthenticationLifetime = DEFAULT_MAXIMUM_AUTHENTICATION_LIFETIME;
}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud