Conversation
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for unsigned-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
yujonglee
force-pushed
the
decouple-tinybase-from-ui-code
branch
from
de23e9f to
f0547e9
Compare
✅ Deploy Preview for fastrepl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4515afa. Configure here.
| } | ||
|
|
||
| return createMissing | ||
| ? getOrCreateSessionForEventId(store, eventId, event.title as string) |
There was a problem hiding this comment.
Render-phase initialization retries on every render when store unavailable
Low Severity
The old guard if (!initialContentRef.current && store) ensured render-time initialization only ran when the store was ready. The new code drops the store check: if dailyNoteRuntime.initializeContent returns null (because the store is undefined), initialContentRef.current stays falsy, causing the initialization to re-execute on every subsequent render until the store becomes available. While functionally self-correcting, this creates unnecessary work during the initial renders when the store hasn't loaded yet, including redundant calls to all the argument-building logic (eventIds, sessionIds, taskStorage, etc.) each time.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4515afa. Configure here.
|
decided to split PR |
1 participant
No description provided.