fix: align live transcript panel with transcript view#5064
fix: align live transcript panel with transcript view#5064ComputelessComputer wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for unsigned-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for char-cli-web canceled.
|
ComputelessComputer
force-pushed
the
fix/live-transcript-view
branch
from
c80aab6 to
c50d3c5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c50d3c5. Configure here.
| message={ | ||
| screen.kind === "ready" | ||
| ? (getTranscriptPreview(screen.liveSegments) ?? "Listening...") | ||
| : "Listening..." |
There was a problem hiding this comment.
Collapsed preview ignores stored transcript segments
Medium Severity
The collapsed footer preview calls getTranscriptPreview(screen.liveSegments), but screen.liveSegments only contains real-time segments from the listener — not stored/persisted transcript segments. When screen.kind is "ready" because hasTranscriptWords is true (e.g., after a session resume) but no live segments have arrived yet, getTranscriptPreview([]) returns null and the user sees "Listening..." instead of the existing transcript text. The old code used useLiveTranscriptSegments which fell back to rendered stored segments when live segments were empty.
Reviewed by Cursor Bugbot for commit c50d3c5. Configure here.
| } | ||
|
|
||
| const SegmentsList = memo( | ||
| export const TranscriptSegmentsList = memo( |
There was a problem hiding this comment.
Exported TranscriptSegmentsList has no external consumer
Low Severity
TranscriptSegmentsList (renamed from the private SegmentsList) is now exported but is not imported by any other file — it's only referenced within transcript.tsx itself. This is an unused export that adds to the public API surface without a consumer.
Reviewed by Cursor Bugbot for commit c50d3c5. Configure here.
|
Since this touch some tinybase stuff #5077 this should be merged first |
Merge the expanded live transcript surface into the session card, reuse transcript rendering for live-only segments, and add coverage for the live viewer path.
ComputelessComputer
force-pushed
the
fix/live-transcript-view
branch
from
c50d3c5 to
f2b144f
Compare
✅ Deploy Preview for fastrepl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 participants
Merge the expanded live transcript surface into the session card, reuse transcript rendering for live-only segments, and add coverage for the live viewer path.
Note
Medium Risk
Moderate UI/behavior changes in the live session footer and transcript renderer; risk is mainly around regressions in live transcript display, scrolling, and playback hotkey behavior when transcript IDs are absent.
Overview
Aligns the expanded live transcript footer with the main transcript UI by replacing the bespoke footer segment rendering with
useTranscriptScreen+TranscriptViewer, including a dedicated listening state and updated container styling.TranscriptViewer/renderer now supports a live-only path where there are no persistedtranscriptIds(treats it as a singleundefinedtranscript), makestranscriptIdoptional throughout rendering/segment keys, and addsenablePlaybackControlsto disable spacebar playback + playback autoscroll when embedded in the live footer; includes a new unit test covering the live-only rendering path.Reviewed by Cursor Bugbot for commit f2b144f. Bugbot is set up for automated code reviews on this repo. Configure here.