Skip to content

#6616 - Hydrogen bond laouted in flex style on snake mode#9534

Open
mariam-khutuashvili wants to merge 1 commit intomasterfrom
6616-hydrogen-bond-laouted-in-flex-style-on-snake-mode
Open

#6616 - Hydrogen bond laouted in flex style on snake mode#9534
mariam-khutuashvili wants to merge 1 commit intomasterfrom
6616-hydrogen-bond-laouted-in-flex-style-on-snake-mode

Conversation

@mariam-khutuashvili
Copy link
Collaborator

@mariam-khutuashvili mariam-khutuashvili commented Mar 24, 2026 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

  • Fix hydrogen bonds being rendered in flex style (straight diagonal lines) instead of snake style (grid-routed with right-angle
    turns) when in snake layout mode
  • Root cause: calculateSnakeLayoutMatrix() built the column-index mapping using only X positions from the longest row.
    Antisense-only nodes extending beyond the sense chain had unmapped X positions, resulting in NaN column indices — their monomers
    were excluded from the canvas matrix, and hydrogen bonds fell back to flex-style rendering
  • Fix: collect all unique X positions across all rows (sorted) when building the column mapping, so every monomer gets a valid
    column index

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@mariam-khutuashvili
#6616 - Fix hydrogen bond rendered in flex style on snake mode
476d1c7 
Use all unique X positions across all rows (not just the longest row)
when building the snake layout matrix column mapping, so antisense-only
nodes that extend beyond the sense chain get valid column indices.
@mariam-khutuashvili mariam-khutuashvili self-assigned this Mar 24, 2026
@auto-assign auto-assign bot requested a review from svvald March 24, 2026 11:56
@mariam-khutuashvili mariam-khutuashvili linked an issue Mar 24, 2026 that may be closed by this pull request
Hydrogen bond laouted in flex style on snake mode #6616
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svvald svvald Awaiting requested review from svvald

At least 1 approving review is required to merge this pull request.

Assignees

@mariam-khutuashvili mariam-khutuashvili

Labels

Fixed by ChatGPT5 Ready for approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hydrogen bond laouted in flex style on snake mode

1 participant

@mariam-khutuashvili