Make Yes the default button on the Qt macOS bugs warning dialogs - #966
Merged
eoyilmaz merged 2 commits intoJul 28, 2026
Merged
Conversation
_check_show_macos_bugs_warning() passed QMessageBox.No as the defaultButton for both the calibration black point correction/black level warning and the profile black point compensation warning, so No rendered as the highlighted/default button instead of Yes, the recommended action.
eoyilmaz
deleted the
964-qt-macos-bugs-warning-dialogs-default-to-no-instead-of-yes
branch
July 28, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MainWindow._check_show_macos_bugs_warning()passedQMessageBox.Noas thedefaultButtonfor both the calibration black point correction/black level warning and the profile black point compensation warning, soNorendered as the highlighted/default button instead ofYes, the recommended action that turns the problematic setting off.QMessageBox.NotoQMessageBox.Yesin bothmessage_box.warning()calls.test_macos_bugs_cal_warning_yes_resets_controlsandtest_macos_bugs_profile_warning_yes_updates_profile_controlsto assert thedefaultButtonargument passed toQMessageBox.warning()isQMessageBox.Yes, so a regression would be caught.Test plan
Yes.pytest tests/test_ui_main_window.py -k macos_bugscould not be run to completion locally due to the dev machine being out of free memory/swap at the time; should be re-run in CI or once the machine has headroom.