Description
The two Qt macOS-bugs warning dialogs shown by MainWindow._check_show_macos_bugs_warning() (DisplayCAL/ui/main_window.py:9307) have their Yes/No/Cancel buttons wired up with No as the default (highlighted/blue) button instead of Yes.
Affected dialogs:
- The calibration black point correction / black level warning (
macos.bugs.cal.warning), DisplayCAL/ui/main_window.py:9322-9328
- The profile black point compensation warning (
macos.bugs.profile.warning), DisplayCAL/ui/main_window.py:9338-9344
Both calls pass QMessageBox.No as the defaultButton argument to message_box.warning():
answer = message_box.warning(
self,
APPNAME,
lang.getstr("macos.bugs.cal.warning"),
QMessageBox.Yes | QMessageBox.No | QMessageBox.Cancel,
QMessageBox.No,
)
Yes is the button that turns off the problematic setting (recommended action), so it should be the default instead.
Fix
Change the defaultButton argument from QMessageBox.No to QMessageBox.Yes in both calls.
Description
The two Qt macOS-bugs warning dialogs shown by
MainWindow._check_show_macos_bugs_warning()(DisplayCAL/ui/main_window.py:9307) have theirYes/No/Cancelbuttons wired up withNoas the default (highlighted/blue) button instead ofYes.Affected dialogs:
macos.bugs.cal.warning),DisplayCAL/ui/main_window.py:9322-9328macos.bugs.profile.warning),DisplayCAL/ui/main_window.py:9338-9344Both calls pass
QMessageBox.Noas thedefaultButtonargument tomessage_box.warning():Yesis the button that turns off the problematic setting (recommended action), so it should be the default instead.Fix
Change the
defaultButtonargument fromQMessageBox.NotoQMessageBox.Yesin both calls.