Skip to content

Fix warnings in 1.20 and require Elixir 1.15+ #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabiwara wants to merge 5 commits into
base: master
Choose a base branch
from
+11 −7
Open

Fix warnings in 1.20 and require Elixir 1.15+ #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5979ab2
Bump ELIXIR_BASE in CI
sabiwara Jan 14, 2026
9ad5e7e
Require Elixir 1.15
sabiwara Jan 14, 2026
88dcbd8
Address deprecated preferred_cli_env warning
sabiwara Jan 14, 2026
97f3f2b
Fix warning about missing pin operator in bitstring pattern
sabiwara Jan 14, 2026
de00859
Add test_ignore_filters to fix warning
sabiwara Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
fail-fast: false
matrix:
elixirbase:
- "1.14.5-erlang-23.3.4.9-alpine-3.16.9"
- "1.15.6-erlang-25.3.2.6-alpine-3.18.4"
Copy link
Contributor Author

@sabiwara sabiwara Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusing the same version as Earthfile here

postgres:
- "16.2-alpine"
- "11.11-alpine"
Expand All @@ -61,7 +61,7 @@ jobs:
pool_count:
- "1"
include:
- elixirbase: "1.14.5-erlang-23.3.4.9-alpine-3.16.9"
- elixirbase: "1.15.6-erlang-25.3.2.6-alpine-3.18.4"
postgres: "16.2-alpine"
pool_count: "4"
steps:
Expand All @@ -79,7 +79,7 @@ jobs:
fail-fast: false
matrix:
elixirbase:
- "1.14.5-erlang-23.3.4.9-alpine-3.16.9"
- "1.15.6-erlang-25.3.2.6-alpine-3.18.4"
mysql:
- "5.7"
- "8.0"
Expand All @@ -96,7 +96,7 @@ jobs:
fail-fast: false
matrix:
elixirbase:
- "1.14.5-erlang-23.3.4.9-alpine-3.16.9"
- "1.15.6-erlang-25.3.2.6-alpine-3.18.4"
mssql:
- "2019"
- "2022"
Expand Down
2 changes: 1 addition & 1 deletion lib/ecto/adapters/postgres/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1991,7 +1991,7 @@ if Code.ensure_loaded?(Postgrex) do

defp bitstring_literal(value) do
size = bit_size(value)
<<val::size(size)>> = value
<<val::size(^size)>> = value

[?b, ?', val |> Integer.to_string(2) |> String.pad_leading(size, ["0"]), ?']
end
Expand Down
8 changes: 6 additions & 2 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ defmodule EctoSQL.MixProject do
[
app: :ecto_sql,
version: @version,
elixir: "~> 1.14",
elixir: "~> 1.15",
deps: deps(),
test_paths: test_paths(System.get_env("ECTO_ADAPTER")),
test_ignore_filters: [&String.starts_with?(&1, "test/support/")],
xref: [
exclude: [
MyXQL,
Expand All @@ -30,7 +31,6 @@ defmodule EctoSQL.MixProject do
"test.adapters": &test_adapters/1,
"test.as_a_dep": &test_as_a_dep/1
],
preferred_cli_env: ["test.all": :test, "test.adapters": :test],

# Hex
description: "SQL-based adapters for Ecto and database migrations",
Expand All @@ -50,6 +50,10 @@ defmodule EctoSQL.MixProject do
]
end

def cli do
[preferred_envs: ["test.all": :test, "test.adapters": :test]]
end

defp deps do
[
ecto_dep(),
Expand Down
Loading