-
Notifications
You must be signed in to change notification settings - Fork 335
Fix warnings in 1.20 and require Elixir 1.15+ #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fc04637 to
de00859
Compare
| matrix: | ||
| elixirbase: | ||
| - "1.14.5-erlang-23.3.4.9-alpine-3.16.9" | ||
| - "1.15.6-erlang-25.3.2.6-alpine-3.18.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing the same version as Earthfile here
|
Ouch it seems this breaks the earthly setup for integration files in the CI, I'm a bit out of my depth here. |
|
When we upgrade the alpine version sometimes the way we were installing things or starting the database becomes incompatible. It’s a bit annoying to debug. I can try to help out but can’t really promise how fast I can fix it |
|
Maybe we should discuss again if we should get rid of Earthfile. |
|
We can probably ask Claude Code to setup a new CI based on our constraints and it may do a reasonable good job at that. And since CI is self verifying, there is a reasonable end goal? |
|
After looking at it closer this isn't entirely correct. See my next message instead. |
|
The MySQL issues seem to be with the output of the dump files. They are not matching exactly what we expected. So I don't expect that to be a major issue to fix. I can look at that. For Postgres I just checked and actually all version are EOL until Postgres 13. We could just stop running 9.5 on the CI and replace it with 13 or 12 or something like that. If we want to immediately unblock this. And actually I made a mistake with my previous message. The database is running in a separate container but it was the client utilities that were failing. There is a comment in the Earthfile that Postgres 9.5 needs to pin its version and can't use newer clients. I don't think we can fix that so probably the only solution is to stop using 9.5 in the CI |
|
Sent a PR with minimal CI changes to get this working for now: #719 That's not to exclude the possibility of redoing the CI but these changes seem reasonable enough to me to get the warnings fixed for elixir 1.20 |
See individual commits.