Skip to content

fix: use modifying word in error message #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggnmstr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use modifying word in error message #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pgduckdb_hooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ IsAllowedStatement(Query *query, bool throw_error) {
if (query->rtable != NULL) {
RangeTblEntry *resultRte = list_nth_node(RangeTblEntry, query->rtable, query->resultRelation - 1);
if (!::IsDuckdbTable(resultRte->relid)) {
elog(elevel, "DuckDB does not support modififying Postgres tables");
elog(elevel, "DuckDB does not support modifying Postgres tables");
return false;
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/pycheck/copy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def test_copy_from_local(cur: Cursor, tmp_path: Path):
# If that's not possible (e.g. due to parquet), then we throw a clear error
with pytest.raises(
psycopg.errors.InternalError,
match="DuckDB does not support modififying Postgres tables",
match="DuckDB does not support modifying Postgres tables",
):
cur.sql(
f"COPY (INSERT INTO pg_table VALUES (1) RETURNING (id)) TO '{parquet_path}'"
Expand Down
Loading