Skip to content

fix: use modifying word in error message#1029

Open
ggnmstr wants to merge 1 commit intoduckdb:mainfrom
ggnmstr:fix-modififying
Open

fix: use modifying word in error message#1029
ggnmstr wants to merge 1 commit intoduckdb:mainfrom
ggnmstr:fix-modififying

Conversation

@ggnmstr
Copy link
Copy Markdown
Contributor

@ggnmstr ggnmstr commented Mar 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 25, 2026 11:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a misspelling in the error message emitted when DuckDB-backed execution encounters a modifying statement targeting a Postgres table, and updates the corresponding test assertion to match.

Changes:

  • Fix typo in elog error message: “modififying” → “modifying”.
  • Update pytest.raises(..., match=...) expectation to the corrected wording.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/pycheck/copy_test.py Updates regex match string to the corrected error message text.
src/pgduckdb_hooks.cpp Fixes the misspelled word in the emitted error message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants