Replace const std::vector& arguments with std::span#14500
Open
Sintendo wants to merge 1 commit intodolphin-emu:masterfrom
Open
Replace const std::vector& arguments with std::span#14500Sintendo wants to merge 1 commit intodolphin-emu:masterfrom
const std::vector& arguments with std::span#14500Sintendo wants to merge 1 commit intodolphin-emu:masterfrom
Conversation
jordan-woyak
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::spanshould be used instead ofconst std::vector&whenever possible:std::spanarguments can efficiently accept many different sequential memory types without needing to create a copy (plain C arrays,std::vector, andstd::array).std::vectoris itself a pointer to heap-allocated memory, passing a reference to one introduces an extra layer of indirection.This PR replaces many such instances, although a few that are less trivial to refactor (e.g.
CalculateDigest) remain.