Use more std::span arguments

Author: Sintendo

Source/Core/Common/Assembler/GekkoLexer.cpp

@@ -486,7 +486,7 @@ void Lexer::EatAndReset()
   SetIdentifierMatchRule(IdentifierMatchRule::Typical);
 }
 
-std::optional<std::string_view> Lexer::RunDfa(const std::vector<DfaNode>& dfa) const
+std::optional<std::string_view> Lexer::RunDfa(std::span<const DfaNode> dfa) const
 {
   size_t dfa_index = 0;
   bool transition_found;

Source/Core/Common/Assembler/GekkoLexer.h

@@ -7,6 +7,7 @@
 #include <array>
 #include <deque>
 #include <optional>
+#include <span>
 #include <string_view>
 #include <vector>
 
@@ -166,7 +167,7 @@ class Lexer
   }
 
 private:
-  std::optional<std::string_view> RunDfa(const std::vector<DfaNode>& dfa) const;
+  std::optional<std::string_view> RunDfa(std::span<const DfaNode> dfa) const;
   void SkipWs() const;
   void FeedbackTokens() const;
   bool IdentifierHeadExtra(char h) const;

Source/Core/Common/Debug/Watches.cpp

@@ -89,7 +89,7 @@ void Watches::RemoveWatch(std::size_t index)
   m_watches.erase(m_watches.begin() + index);
 }
 
-void Watches::LoadFromStrings(const std::vector<std::string>& watches)
+void Watches::LoadFromStrings(std::span<const std::string> watches)
 {
   for (const std::string& watch : watches)
   {

Source/Core/Common/Debug/Watches.h

@@ -4,6 +4,7 @@
 #pragma once
 
 #include <cstddef>
+#include <span>
 #include <string>
 #include <vector>
 
@@ -42,7 +43,7 @@ class Watches
   void DisableWatch(std::size_t index);
   bool HasEnabledWatch(u32 address) const;
   void RemoveWatch(std::size_t index);
-  void LoadFromStrings(const std::vector<std::string>& watches);
+  void LoadFromStrings(std::span<const std::string> watches);
   std::vector<std::string> SaveToStrings() const;
   void Clear();
 

Source/Core/Common/HttpRequest.cpp

@@ -96,13 +96,13 @@ HttpRequest::Response HttpRequest::Get(const std::string& url, const Headers& he
   return m_impl->Fetch(url, Impl::Method::GET, headers, nullptr, 0, codes);
 }
 
-HttpRequest::Response HttpRequest::Post(const std::string& url, const std::vector<u8>& payload,
+HttpRequest::Response HttpRequest::Post(const std::string& url, std::span<const u8> payload,
                                         const Headers& headers, AllowedReturnCodes codes)
 {
   return m_impl->Fetch(url, Impl::Method::POST, headers, payload.data(), payload.size(), codes);
 }
 
-HttpRequest::Response HttpRequest::Post(const std::string& url, const std::string& payload,
+HttpRequest::Response HttpRequest::Post(const std::string& url, std::string_view payload,
                                         const Headers& headers, AllowedReturnCodes codes)
 {
   return m_impl->Fetch(url, Impl::Method::POST, headers,

Source/Core/Common/HttpRequest.h

@@ -10,6 +10,7 @@
 #include <optional>
 #include <span>
 #include <string>
+#include <string_view>
 #include <vector>
 
 #include "Common/CommonTypes.h"
@@ -50,9 +51,9 @@ class HttpRequest final
   std::string GetHeaderValue(std::string_view name) const;
   Response Get(const std::string& url, const Headers& headers = {},
                AllowedReturnCodes codes = AllowedReturnCodes::Ok_Only);
-  Response Post(const std::string& url, const std::vector<u8>& payload, const Headers& headers = {},
+  Response Post(const std::string& url, std::span<const u8> payload, const Headers& headers = {},
                 AllowedReturnCodes codes = AllowedReturnCodes::Ok_Only);
-  Response Post(const std::string& url, const std::string& payload, const Headers& headers = {},
+  Response Post(const std::string& url, std::string_view payload, const Headers& headers = {},
                 AllowedReturnCodes codes = AllowedReturnCodes::Ok_Only);
 
   Response PostMultiform(const std::string& url, std::span<Multiform> multiform,

Source/Core/Common/Network.cpp

@@ -462,7 +462,7 @@ DHCPBody::DHCPBody(u32 transaction, const MACAddress& client_address, u32 new_ip
 
 DHCPPacket::DHCPPacket() = default;
 
-DHCPPacket::DHCPPacket(const std::vector<u8>& data)
+DHCPPacket::DHCPPacket(std::span<const u8> data)
 {
   if (data.size() < DHCPBody::SIZE)
     return;
@@ -489,13 +489,13 @@ DHCPPacket::DHCPPacket(const std::vector<u8>& data)
   }
 }
 
-void DHCPPacket::AddOption(u8 fnc, const std::vector<u8>& params)
+void DHCPPacket::AddOption(u8 fnc, std::span<const u8> params)
 {
   if (params.size() > 255)
     return;
   std::vector<u8> opt = {fnc, u8(params.size())};
   opt.insert(opt.end(), params.begin(), params.end());
-  options.emplace_back(std::move(opt));
+  options.push_back(std::move(opt));
 }
 
 std::vector<u8> DHCPPacket::Build() const
@@ -507,7 +507,7 @@ std::vector<u8> DHCPPacket::Build() const
   {
     result.insert(result.end(), opt.begin(), opt.end());
   }
-  const std::vector<u8> no_option = {255, 0, 0, 0};
+  constexpr auto no_option = std::to_array<u8>({255, 0, 0, 0});
   result.insert(result.end(), no_option.begin(), no_option.end());
 
   return result;

Source/Core/Common/Network.h

@@ -5,6 +5,7 @@
 
 #include <array>
 #include <optional>
+#include <span>
 #include <string>
 #include <string_view>
 #include <type_traits>
@@ -183,8 +184,8 @@ static_assert(sizeof(DHCPBody) == DHCPBody::SIZE);
 struct DHCPPacket
 {
   DHCPPacket();
-  DHCPPacket(const std::vector<u8>& data);
-  void AddOption(u8 fnc, const std::vector<u8>& params);
+  DHCPPacket(std::span<const u8> data);
+  void AddOption(u8 fnc, std::span<const u8> params);
   std::vector<u8> Build() const;
 
   DHCPBody body;

Source/Core/Core/Boot/DolReader.cpp

@@ -31,7 +31,7 @@ DolReader::DolReader(const std::string& filename) : BootExecutableReader(filenam
 
 DolReader::~DolReader() = default;
 
-bool DolReader::Initialize(const std::vector<u8>& buffer)
+bool DolReader::Initialize(std::span<const u8> buffer)
 {
   if (buffer.size() < sizeof(SDolHeader) || buffer.size() > UINT32_MAX)
     return false;

Source/Core/Core/Boot/DolReader.h

@@ -65,7 +65,7 @@ class DolReader final : public BootExecutableReader
   bool m_is_ancast;
 
   // Copy sections to internal buffers
-  bool Initialize(const std::vector<u8>& buffer);
+  bool Initialize(std::span<const u8> buffer);
 
   bool LoadAncastIntoMemory(Core::System& system) const;
 };