Skip to content

test: fix failing e2e test #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srdtrk merged 3 commits into from
Mar 19, 2025
Merged

test: fix failing e2e test #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
568cadc
test: fix failing e2e
gjermundgaraba Mar 19, 2025
50efc6d
lint
gjermundgaraba Mar 19, 2025
27836d2
add receipt check to eth.BroadcastTx
gjermundgaraba Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/interchaintestv8/chainconfig/kurtosis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ var (
ElectraForkEpoch: 1,
},
WaitForFinalization: true,
AdditionalServices: []string{},
}
executionService = fmt.Sprintf("el-1-%s-%s", kurtosisConfig.Participants[0].ELType, kurtosisConfig.Participants[0].CLType)
consensusService = fmt.Sprintf("cl-1-%s-%s", kurtosisConfig.Participants[0].CLType, kurtosisConfig.Participants[0].ELType)
Expand All @@ -63,6 +64,7 @@ type kurtosisNetworkParams struct {
Participants []kurtosisParticipant `json:"participants"`
NetworkParams kurtosisNetworkConfigParams `json:"network_params"`
WaitForFinalization bool `json:"wait_for_finalization"`
AdditionalServices []string `json:"additional_services"`
Copy link
Contributor Author

@gjermundgaraba gjermundgaraba Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically not related, but I did use to while testing to add an explorer to help me a bit, so figured we can just keep this around so it's easier to use.

}

type kurtosisParticipant struct {
Expand Down
4 changes: 4 additions & 0 deletions e2e/interchaintestv8/ethereum/ethereum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ func (e *Ethereum) BroadcastTx(ctx context.Context, userKey *ecdsa.PrivateKey, g
return nil, err
}

if receipt != nil && receipt.Status != ethtypes.ReceiptStatusSuccessful {
return nil, fmt.Errorf("eth transaction was broadcasted, but failed on-chain with status %d", receipt.Status)
}

return receipt, nil
}

Expand Down
9 changes: 7 additions & 2 deletions e2e/interchaintestv8/relayer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,8 +1026,13 @@ func (s *RelayerTestSuite) ICS20TimeoutFromCosmosTimeoutTest(

s.Require().True(s.Run("Receive packets on Ethereum after timeout should fail", func() {
ics26Address := ethcommon.HexToAddress(s.contractAddresses.Ics26Router)
receipt, err := eth.BroadcastTx(ctx, s.EthRelayerSubmitter, 5_000_000, ics26Address, txBodyBz)
_, err := eth.BroadcastTx(ctx, s.EthRelayerSubmitter, 5_000_000, ics26Address, txBodyBz)
s.Require().Error(err)

// Prove that the erc20 was not created (and by extension, the packet was not received)
denomOnEthereum := transfertypes.NewDenom(transferCoin.Denom, transfertypes.NewHop(transfertypes.PortID, testvalues.CustomClientID))
_, err = s.ics20Contract.IbcERC20Contract(nil, denomOnEthereum.Path())
// Ethereum side did not received the packet, ERC20 contract corresponding to the denom does not exist
s.Require().Error(err)
s.Require().Nil(receipt)
}))
}
Loading