Skip to content

test: fix failing e2e test#426

Merged
srdtrk merged 3 commits intomainfrom
gjermund/fix-failing-e2e
Mar 19, 2025
Merged

test: fix failing e2e test#426
srdtrk merged 3 commits intomainfrom
gjermund/fix-failing-e2e

Conversation

@gjermundgaraba
Copy link
Contributor

Description

Fixes the failing test in PoS.
Proof: https://github.com/cosmos/solidity-ibc-eureka/actions/runs/13946430405 (the lint has since been fixed)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba requested a review from srdtrk as a code owner March 19, 2025 13:38
@gjermundgaraba gjermundgaraba changed the title Gjermund/fix failing e2e test: fix failing e2e test Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (67eeb10) to head (27836d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         744      744           
=======================================
  Hits          743      743           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Participants []kurtosisParticipant `json:"participants"`
NetworkParams kurtosisNetworkConfigParams `json:"network_params"`
WaitForFinalization bool `json:"wait_for_finalization"`
AdditionalServices []string `json:"additional_services"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically not related, but I did use to while testing to add an explorer to help me a bit, so figured we can just keep this around so it's easier to use.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I just have one question but this can be merged regardless.

@srdtrk srdtrk merged commit 7848646 into main Mar 19, 2025
102 of 104 checks passed
@srdtrk srdtrk deleted the gjermund/fix-failing-e2e branch March 19, 2025 14:59
gjermundgaraba added a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants