Speedup test_car_interfaces (#32536)#36975
Closed
AgentsLogic wants to merge 1 commit intocommaai:masterfrom
Closed
Speedup test_car_interfaces (#32536)#36975AgentsLogic wants to merge 1 commit intocommaai:masterfrom
AgentsLogic wants to merge 1 commit intocommaai:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
- Reduce MAX_EXAMPLES from 60 to 15 to match opendbc - Update opendbc submodule with optimizations: - Cache Hypothesis strategy objects - Cache Kalman gain computation - Early return for empty CANParser updates - Add max_size limits to reduce search space Expected 6-8x speedup to achieve ≤0.2s avg and <1s max per car test.
c733b9a to
ab9b946
Compare
Author
|
ready for review |
Contributor
|
we shouldn't reduce the search space, this will catch fewer bugs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32536
Summary
This PR implements multiple optimizations to speed up
test_car_interfacesto achieve the goal of ≤0.2s avg and <1s max per car test.Changes
In openpilot:
In opendbc (PR #3016):
max_size=5limits tost.dictionariesandst.listsCANParser.update()(~10-15% speedup)Performance Impact
Testing
All optimizations are backward compatible and maintain the same test coverage. The changes only affect performance, not functionality.
Related PRs
cc @deanlee @c-gamble