Conversation
96f0549 to
4a210c8
Compare
4a210c8 to
9c6c60c
Compare
9c6c60c to
0d76749
Compare
|
FYI, I think this is directionally correct, but you should be aware: I don't think we want to write our own Python extensions instead (~70% sure about this). I think we should start by porting more to native Python, like #35854, then after all that's done, we decide what to do with the remaining C++. |
|
Thanks for the feedback! I did my best to break it up into separate PRs that could all be merged atomically, leaving this PR until the very end. At your recommendation, I updated the first three PRs (#36829, #36830, and #36831) to convert the Cython mainly to Python instead of C++. Hopefully that's closer to what you're looking for. If so, I'll get started on converting the remaining PRs, including this one. |
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Description
This is the parent PR which fully removes cython from openpilot (part 10 of 10). This potentially opens the door to reopening and completing commaai/opendbc#2799
It depends on the following PRs:
Actual changes in this PR:
TODO:
Verification

op testbefore these changes:op testafter these changes: