Skip to content

Fix model-element assets getting duplicated directory on copy #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsblank merged 1 commit into from
Feb 13, 2026
Merged

Fix model-element assets getting duplicated directory on copy #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions cometx/cli/copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,10 +1356,27 @@ def _log_asset(
else:
asset_map[old_asset_id] = result["assetId"]
elif asset_type == "model-element":
name = os.path.basename(filename)
result = experiment.log_model(name, filename)
dir_name = assets_metadata[log_filename].get("dir", "")
# The dir field includes a "models/" prefix added by the
# backend; strip it to get the actual model name.
if dir_name.startswith("models/"):
model_name = dir_name[len("models/"):]
else:
model_name = dir_name
binary_io = open(filename, "rb")
result = experiment._log_asset(
binary_io,
file_name=log_as_filename or log_filename,
copy_to_tmp=True,
asset_type=asset_type,
metadata=metadata,
step=step,
grouping_name=model_name,
)
if result is None:
print(f"ERROR: Unable to log {asset_type} asset {name}; skipping")
print(
f"ERROR: Unable to log {asset_type} asset {log_as_filename or log_filename}; skipping"
)
else:
asset_map[old_asset_id] = result["assetId"]
else:
Expand Down