Fix model-element assets getting duplicated directory on copy#18
Merged
Fix model-element assets getting duplicated directory on copy#18
Conversation
When copying model-element assets, log_model() was called with the file's basename as the model name (e.g., "model.onnx"), causing a duplicate folder structure like model.onnx/model.onnx. Instead, use _log_asset() directly with the correct grouping_name extracted from the asset's "dir" metadata field, stripping the "models/" prefix that the backend adds automatically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cometx copycreating duplicated directory structures for model-element assets (e.g.,model.onnx/model.onnx)experiment.log_model(name, file)was using the file's basename as the model name, causing each file to become its own model folderexperiment._log_asset()directly withgrouping_nameextracted from the asset'sdirmetadata field, stripping themodels/prefix that the backend adds automaticallyTest plan
dsblank/general/e7e58746cc3d4302acc36bae917dfc57with model-element assetsdsblank/model-testand verified model assets no longer show duplicated directory structure🤖 Generated with Claude Code