Skip to content

Improve network reliability and headers in build utilities #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonede merged 3 commits into from
Feb 27, 2026
Merged

Improve network reliability and headers in build utilities #132

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a197246
enh: add User-Agent and timeouts to Utils network requests
DavidBakerEffendi Feb 26, 2026
e2c1ae3
enh: allow custom Accept header in Utils downloadFile methods
DavidBakerEffendi Feb 26, 2026
81d7f6e
refactor: use withCloseable for input stream in Utils
DavidBakerEffendi Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions buildSrc/src/main/groovy/org/treesitter/build/Utils.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,27 +145,33 @@ abstract class Utils {
]
}

static void downloadFile(URL url, File dest){
static void downloadFile(URL url, File dest, String accept = "application/zip"){
url.openConnection().with { conn ->
conn.setRequestProperty("User-Agent", "Mozilla/5.0")
conn.setRequestProperty("Accept", accept)
conn.setConnectTimeout(30000)
conn.setReadTimeout(30000)
dest.withOutputStream { output ->
conn.inputStream.with {input ->
conn.inputStream.withCloseable { input ->
output << input
input.close()
}
}
}
}

static String fetchUrl(URL url){
return url.openConnection().with { conn ->
conn.setRequestProperty("User-Agent", "Mozilla/5.0")
conn.setConnectTimeout(30000)
conn.setReadTimeout(30000)
conn.inputStream.withCloseable { input ->
return input.text
}
}
}

static void downloadFile(String url, File dest){
downloadFile(new URL(url), dest)
static void downloadFile(String url, File dest, String accept = "application/zip"){
downloadFile(new URL(url), dest, accept)
}

static unzipFile(File zipFile, File outputDir) {
Expand Down
Loading