You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Focusing on helping fix the failing/flaky CI/CD, this PR enhances the network reliability and compatibility of the build script's file downloading and fetching utilities.
Key changes include:
Added User-Agent and Accept headers to HTTP requests to prevent connection rejection by servers that require standard browser identifiers.
Implemented connection and read timeouts (30 seconds) to prevent the build process from hanging indefinitely during network instability.
Improved resource management by using withCloseable in downloadFile to ensure input streams are properly released.
Updated downloadFile signatures to support a configurable Accept header, defaulting to application/zip.
These modifications ensure a more robust build process, especially when fetching grammar files or dependencies from external repositories.
Seems windows is giving an issue on Scala again. Looking into this now...
The build failure on Windows is caused by a java.nio.file.AccessDeniedException when NativeUtils.loadLib attempts to overwrite an existing native library (.dll) that is currently locked by a running process (likely the Gradle Daemon or another test thread).
On Windows, loaded DLLs cannot be deleted or overwritten. When NativeUtils detects a CRC mismatch (e.g., after a rebuild), it attempts to update the cached DLL in ~/.tree-sitter/ using Files.move, which fails if the file is locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focusing on helping fix the failing/flaky CI/CD, this PR enhances the network reliability and compatibility of the build script's file downloading and fetching utilities.
Key changes include:
User-AgentandAcceptheaders to HTTP requests to prevent connection rejection by servers that require standard browser identifiers.withCloseableindownloadFileto ensure input streams are properly released.downloadFilesignatures to support a configurableAcceptheader, defaulting toapplication/zip.These modifications ensure a more robust build process, especially when fetching grammar files or dependencies from external repositories.