Fix 2d specialization w/ change lists.#23083
Open
tychedelia wants to merge 1 commit intobevyengine:mainfrom
Open
Fix 2d specialization w/ change lists.#23083tychedelia wants to merge 1 commit intobevyengine:mainfrom
tychedelia wants to merge 1 commit intobevyengine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes for 2d post #22966.
This is complicated because, unlike 3d, 2d material systems are generic over their material and not type erased. Which means we have to be defensive against all the weird scenarios that can happen when different material systems race against each other.
I am not confident this is correct. The ultimate solution is just to get rid of all these bespoke 2d systems.
The main fixes are:
material_bind_group_idis no longer reset to default every frame.extract_mesh2dwas settingmaterial_bind_group_idon every extraction. Previously this was overwritten later during queuing every frame, but with dirty tracking, entities aren't re-queued every frame so the default sticks.prepare_for_new_framemoved to a non-generic system.