The testbed_ui text scene should use a column layout #22976#23077
Open
kaio-matos wants to merge 3 commits intobevyengine:mainfrom
Open
The testbed_ui text scene should use a column layout #22976#23077kaio-matos wants to merge 3 commits intobevyengine:mainfrom
testbed_ui text scene should use a column layout #22976#23077kaio-matos wants to merge 3 commits intobevyengine:mainfrom
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
alice-i-cecile
approved these changes
Feb 20, 2026
ickshonpe
approved these changes
Feb 20, 2026
Contributor
ickshonpe
left a comment
There was a problem hiding this comment.
Yep looks much better, don't see any problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove unnecessary usage of absolute positioning for each text element
Fixes #22976
Solution
Uses display grid with two columns to display the
testbed_uitext.Beyond that I removed
DespawnOnExit(super::Scene::Text)from each text element and added that only to the parent component.Testing
Run and hit space once: