add gamepad to bevy_gilrs feature flag #22320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Dec 31, 2025
kfc35
approved these changes
Dec 31, 2025
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Tangent: Does this mean mouse keyboard touch and gestures are also not configured correctly? The docs say that those features are "Automatically enabled by bevy_window” but it seems to not be configured like how this fix is for gamepad and bevy_gilrs
Contributor
Author
|
I was thinking about similar things. The entire doc should probably be audited to be sure. |
hukasu
approved these changes
Dec 31, 2025
hukasu
added
C-Docs
alice-i-cecile
approved these changes
Dec 31, 2025
cart
pushed a commit
that referenced
this pull request
Jan 8, 2026
# Objective - Resolve discrepancy between documentation and implementation of the `bevy_gilrs` and `gamepad` feature flag - Fixes #22319 ## Solution - Added `gamepad` to `bevy_gilrs` per the documentation ## Testing - I recompiled Bevy with and without this change and ensured no failure to compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_gilrsandgamepadfeature flagSolution
gamepadtobevy_gilrsper the documentationTesting