chore: Refactor CometExecRule handling of exchanges [WIP]#2848
Closed
andygrove wants to merge 20 commits intoapache:mainfrom
Closed
chore: Refactor CometExecRule handling of exchanges [WIP]#2848andygrove wants to merge 20 commits intoapache:mainfrom
CometExecRule handling of exchanges [WIP]#2848andygrove wants to merge 20 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
=============================================
- Coverage 56.12% 42.40% -13.73%
- Complexity 976 983 +7
=============================================
Files 119 167 +48
Lines 11743 15200 +3457
Branches 2251 2512 +261
=============================================
- Hits 6591 6445 -146
- Misses 4012 7726 +3714
+ Partials 1140 1029 -111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CometExecRule handling of exchanges [WIP]CometExecRule handling of exchanges
339f744 to
59ae3a8
Compare
CometExecRule handling of exchangesCometExecRule handling of exchanges [WIP]
Member
Author
|
I am going to break this out into some smaller PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follows on from #2844
Rationale for this change
Clean up hacky convoluted code and use the serde framework for exchanges for more consistency.
The size of
CometExecRuleis reduced from ~900 lines to ~500 lines with this PR.What changes are included in this PR?
CometExecRule.operator2Proto🎉CometBroadcastExchangeExecandCometShuffleExchangeExecnow implementCometSinkCometShuffleExchangeExecrequiresNativeChildrentoCometOperatorSerdeso we no longer need methods likeconvertToCometandconvertToCometIfAllChildrenAreNative. It makes more sense for each operator to know whether it requires native children.How are these changes tested?