chore: Refactor some of the scan and sink handling in CometExecRule to reduce duplicate code#2844
Merged
andygrove merged 16 commits intoapache:mainfrom Dec 4, 2025
Merged
Conversation
andygrove
changed the title
CometExecRule to remove duplicate codeCometExecRule to reduce duplicate code
andygrove
commented
Dec 3, 2025
| */ | ||
| private def operator2Proto(op: SparkPlan, childOp: Operator*): Option[Operator] = { | ||
|
|
||
| def isCometSink(op: SparkPlan): Boolean = { |
Member
Author
There was a problem hiding this comment.
This method was moved and and modified to remove the check for isCometScan since scans are no longer handled in this code
andygrove
commented
Dec 3, 2025
| } | ||
| } | ||
|
|
||
| def isExchangeSink(op: SparkPlan): Boolean = { |
Member
Author
There was a problem hiding this comment.
This method was moved without modification
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
============================================
+ Coverage 56.12% 59.14% +3.01%
- Complexity 976 1471 +495
============================================
Files 119 167 +48
Lines 11743 15235 +3492
Branches 2251 2513 +262
============================================
+ Hits 6591 9010 +2419
- Misses 4012 4942 +930
- Partials 1140 1283 +143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
approved these changes
Dec 4, 2025
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Nice cleanup, @andygrove! Thank you! Approved pending CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Make code easier to comprehend and remove some duplicate code.
What changes are included in this PR?
CometExecRule.operator2Protoare removed and the serde framework is used instead. There is a follow up PR chore: RefactorCometExecRulehandling of exchanges [WIP] #2848 to completely remove this method.CometExchangeSinkCometSparkToColumnarExecCometScanWrapperHow are these changes tested?