fix: parse EC egress CA keys#12
Merged
Merged
Conversation
noa-lucent
approved these changes
Jun 16, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Review complete. The CA loader now accepts cert-manager EC private keys while preserving PKCS#8 and PKCS#1 RSA support, the key type is tightened to crypto.Signer, and the added EC PEM coverage exercises the reported deployment format. CI is green and local CGO-disabled validation passes. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks agynio/architecture#155 and Bootstrap agynio/bootstrap#570 after release.
Validation
CGO_ENABLED=0 go test ./internal/egress/...- pass: 1 package, 0 failed.CGO_ENABLED=0 go vet ./internal/egress/...- pass: no issues.Note:
go test ./internal/egress/...withoutCGO_ENABLED=0cannot run in this local container because gcc is not installed; CI installs gcc.