fix: wire egress gateway self-enrollment#570
Conversation
|
Status update for #153:
Local validation:
Note: the previous full-apply failure was caused by the deployed Secrets chart lacking |
|
Follow-up fix for CI failure:
Local validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Review complete. Bootstrap now wires the enrollment Secret plus writable identity volume and pins the runtime chart versions needed for the chain. Verified terraform fmt -check and terraform validate for stacks/platform after init.
|
Follow-up fixes pushed for the full-apply failures. Changes:
Root cause on the Ziti port failure:
Validation run for bootstrap changes:
|
|
Follow-up CI wiring fix pushed: What changed:
Test & lint summary:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The bootstrap workflow provider staging fix looks correct: it builds terraform-provider-agyn PR #81 into a real file path and passes that file to the e2e action. Terraform validation and diff checks pass locally. The remaining egress image availability issue is tracked on egress#14/e2e#207 rather than bootstrap.
|
Follow-up for downstream image availability pushed: Although this PR was already approved, I added the same guard here so bootstrap full-apply also cannot race the egress PR image publication:
Local validation:
|
|
Updated bootstrap full-apply to consume the latest egress backend fix image. Pushed What changed:
Local validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
I re-reviewed the updated image pin/wait wiring. The workflow now waits for and exports the egress PR image tag before provisioning, which addresses the previous image-availability concern in this PR.
I am not approving this yet because the pinned egress PR still has a remaining backend reconciliation issue (host.v1.address is not included in drift detection). Once agynio/egress#14 is fixed, this downstream pin should be good to proceed.
|
Updated bootstrap downstream pin after the egress reconciliation-drift fix. Pushed What changed:
Local validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The workflow now waits for and exports the updated egress PR image tag pr-14-6bd908c0bb48895ab55cccdeaf20c4ae4e707908 before provisioning, matching the fixed egress#14 head. No further issues found in the updated pin.
Local check: git diff --check passed.
|
Updated bootstrap to consume the new egress PR image containing the service-policy role fix. Summary:
Validation:
Commits:
CI currently pending: |
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The downstream workflow now waits for and exports the updated egress PR image tag pr-14-1df3c611e8474c71de8f611f6dde1edf62f64719, matching the latest fixed egress#14 head. No further issues found in this update.
Local check: git diff --check passed.
2d47ecf to
43dc619
Compare
|
Updated bootstrap to deploy a ziti-management build that implements the service reconcile RPCs required by the egress service-role fix. Summary:
Validation:
Commit:
CI currently pending: |
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The bootstrap workflow now waits for the ziti-management PR image and exports TF_VAR_ziti_management_image_tag before provisioning, so the deployment chain consumes the GetService-capable ziti-management image. No further issues found.
Local check: git diff --check passed.
|
Updated downstream pin to the newly published ziti-management PR image. Commit:
Image:
Validation:
CI:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The bootstrap workflow now waits for and exports the updated ziti-management PR image tag pr-61-138daaf29682b3d1fbc0ba695318c15bb3ece6aa, matching the latest idempotency/publish fixes. No further issues found.
Local check: git diff --check passed.
|
Updated to the latest ziti-management PR image after api#146 wire-compatibility and ziti-management response follow-up. Commit:
Confirmed duplicate config failure:
Image:
Validation:
CI:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The bootstrap workflow now waits for and exports the ziti-management image tag pr-61-d81d5dc495ac4860c88206418cbbb9fccb59b0c3, matching the API-compatible ziti-management head. No further issues found.
Local check: git diff --check passed.
|
Updated egress image pin to the current egress#14 PR image. Commit:
Image pins now used by bootstrap#570:
I verified the current egress PR image exists with Validation:
CI:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Final re-review complete. The console-app image override from the prior blocker has been removed, the previously flagged thread is resolved, local Terraform validation for the platform stack passes, and the latest full-apply check is green. Approving.
|
Blocking this PR pending correction. The workflow must not use PR images, PR image waits, branch refs, or PR-built dependency artifacts. Everything in Bootstrap must consume main/released artifacts only. Required before human review/merge:
|
|
Updated Bootstrap #570 to remove the unacceptable CI dependency chain and keep only the production/mainline-compatible egress gateway self-enrollment wiring. Summary:
Files changed in the final diff vs
Validation:
Head commit: |
aa659c0 to
7ce93aa
Compare
|
Correction pushed: I rewrote the existing PR branch onto Current PR head: Verified remote PR state:
Final change scope:
Validation:
|
|
Pushed a follow-up fix for the fresh full-apply failure. Head commit: Root cause from run
Fix applied, still with no PR images/branch refs/provider PR build/CI dependency chain:
Current PR diff still only changes:
Validation:
|
20be06f to
c2f74f9
Compare
|
Addressed the runners env review feedback and pushed the correction. Head commit: What changed:
Why those runners env entries were added:
Effect on the full-apply failure diagnosis:
Constraints verified:
Validation:
|
Current Bootstrap #570 blocker diagnosisThe current Bootstrap #570 branch is structurally clean and still only consumes main/released artifacts. The latest full-apply failure is not caused by Bootstrap workflow pins or unreleased artifacts. Root causes found in released upstream runtime artifacts:
ValidationEgress Gateway PR:
Ziti Management PR:
Next actionDo not rerun Bootstrap #570 full-apply yet. Merge/release the upstream fixes first, then update this PR to consume the new released chart versions only:
After those released artifacts are available and |
c2f74f9 to
cb5ebf3
Compare
Released chart bump pushed; full-apply rerun failed in provisioningPushed commit Released chart versions now consumed from
The PR remains minimal: only Validation before push:
Triggered run:
Failure observed in released artifacts:
This means the previous |
Follow-up upstream fix opened for remaining ziti-management blockerI diagnosed the current Bootstrap run failure ( Root cause:
Upstream fix PR opened:
What PR #75 changes:
Validation on PR #75:
Bootstrap #570 should remain on released artifacts only. Next required action is to merge/release ziti-management after PR #75, then update this PR to the new released ziti-management chart version and rerun full-apply. No PR images, branch refs, provider PR builds, or workflow dependency chains are needed. |
Follow-up upstream fix opened for service-policy filter blockerDiagnosed Bootstrap run Progress:
Upstream fix PR opened:
What PR #76 changes:
Validation on PR #76:
Bootstrap #570 remains on released artifacts only. Next action is review/merge/release ziti-management PR #76, then bump this PR to the new released ziti-management chart version and rerun full-apply. |
UpdateRemoved the explicit Root cause from run This stays on released/main artifacts only; no PR images, branch refs, provider PR builds, or CI dependency chain were added. Test & Lint Summary
Tests: 0 failed. Lint/format validation passed with no errors. |
noa-lucent
left a comment
There was a problem hiding this comment.
Final re-review complete. The PR is now back on released/main artifacts, keeps the prior console-app override removed, consumes the released ziti-management fixes through chart version 0.10.17, removes the incorrect agents-orchestrator EGRESS_CA_NAMESPACE override, and the latest full-apply is green. Local Terraform validation also passes. Approving.
Summary
ziti_identity.egress_gateway/egress_gateway_enrollment_token/kubernetes_secret_v1.egress_gateway_enrollmentas the bootstrap path./var/lib/zitivolume for the egress-gateway runtime to self-enroll.noa/issue-153-continueduring full-apply and passes the built provider binary into e2e, so bootstrap CI recognizesagyn_egress_ruleandagyn_egress_rule_attachmentuntil provider Fix platform-ui replica count #81 lands.Linked to agynio/architecture#153 and follows up on #569 review feedback.
Runtime/chart support PRs:
Test & Lint Summary
terraform -chdir=stacks/platform fmt -check -diff— passed.terraform -chdir=stacks/platform init -backend=false— passed.terraform -chdir=stacks/platform validate— passed.actionlint .github/workflows/bootstrap.yml— passed with no errors.git diff --check— passed with no whitespace errors.go build -o /tmp/terraform-provider-agyn .from terraform-provider-agyn PR Fix platform-ui replica count #81 branch — passed.go test -run '^$' -tags 'e2e svc_gateway tf_provider_agyn' ./testsfrom e2e/suites/go-terraform — passed: 1 package, failed: 0, skipped: 0; no tests run in compile-only mode.go vet -tags 'e2e svc_gateway tf_provider_agyn' ./testsfrom e2e/suites/go-terraform — passed with no errors.Notes
provider-bin/terraform-provider-agynrather than the repository root, becausego build -o ../terraform-provider-agyn .would create a binary inside the existing checkout directory and would not satisfy the e2e action's file check.