Read every page of a member's organizations - #156
Merged
Conversation
The name is the skill's directory on the agent's filesystem, so the form states the rule instead of surfacing a server error, and the description is required: it is what the agent reads before it opens the body.
Which organizations the console shows is decided from the caller's memberships, and it asked for one page of them. A member of more than two hundred saw the rest disappear -- and because the console falls back to the first organization alphabetically whenever the persisted choice is not among the ones it can see, opening one of the missing organizations by address quietly landed on a different one instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console decides which organizations to show from
ListMyMemberships, and asked for a single page of 200. A member of more than that saw the rest disappear.It fails worse than it sounds: the context falls back to the first organization alphabetically whenever the persisted choice is not among the ones it can see. So opening a missing organization by address quietly rendered a different organization's page — same URL, someone else's data on screen.
Found on the local VM, where the e2e account has 244 active memberships: every console spec that created an organization and navigated to it landed on the alphabetically-first organization instead, and the failures read as missing page elements rather than as the wrong page.
Covered by a unit test that puts the stored organization on the second page; it fails on the old single-page read.