Read every page of a member's organizations (#156)

* Ask for a skill's trigger, and a name that can be a directory

The name is the skill's directory on the agent's filesystem, so the form
states the rule instead of surfacing a server error, and the description
is required: it is what the agent reads before it opens the body.

* Read every page of a member's organizations

Which organizations the console shows is decided from the caller's
memberships, and it asked for one page of them. A member of more than
two hundred saw the rest disappear -- and because the console falls back
to the first organization alphabetically whenever the persisted choice
is not among the ones it can see, opening one of the missing
organizations by address quietly landed on a different one instead.

Author: vitramir

src/__tests__/organization-context.test.tsx

@@ -336,4 +336,51 @@ describe('OrganizationContext', () => {
       expect(screen.getByTestId('pending-ids').textContent).toBe('pending-1,pending-2');
     });
   });
+
+  // A member of more than one page's worth had the rest silently disappear --
+  // including, for anyone near the boundary, the organization they had just
+  // made and asked to open.
+  it('reads every page of memberships, not just the first', async () => {
+    const onPageTwo = create(MembershipSchema, {
+      id: 'membership-late',
+      organizationId: 'org-late',
+      identityId: 'identity-1',
+      role: MembershipRole.OWNER,
+      status: MembershipStatus.ACTIVE,
+    });
+    listMyMemberships.mockImplementation((request: { status?: MembershipStatus; pageToken?: string }) => {
+      if (request?.status === MembershipStatus.PENDING) {
+        return Promise.resolve({ memberships: [] });
+      }
+      if (!request?.pageToken) {
+        return Promise.resolve({
+          memberships: [
+            create(MembershipSchema, {
+              id: 'membership-early',
+              organizationId: 'org-early',
+              identityId: 'identity-1',
+              role: MembershipRole.OWNER,
+              status: MembershipStatus.ACTIVE,
+            }),
+          ],
+          nextPageToken: 'page-2',
+        });
+      }
+      return Promise.resolve({ memberships: [onPageTwo] });
+    });
+    mockOrganizationLookup([
+      { id: 'org-early', name: 'Org Early' },
+      { id: 'org-late', name: 'Org Late' },
+    ]);
+    window.localStorage.setItem(
+      'console.contextMode',
+      JSON.stringify({ mode: 'organization', organizationId: 'org-late' }),
+    );
+
+    renderWithProviders();
+
+    await waitFor(() => {
+      expect(screen.getByTestId('selected').textContent).toBe('org-late');
+    });
+  });
 });

src/context/OrganizationContext.tsx

@@ -101,6 +101,25 @@ function mapOrganizations(
   });
 }
 
+// Every page of them, not the first. Which organizations the console will show
+// is decided from this list, and a member of more than one page's worth had the
+// rest silently disappear -- including, for anyone near the boundary, the
+// organization they had just made and asked to open.
+async function listAllMyMemberships(status: MembershipStatus): Promise<{ memberships: Membership[] }> {
+  const memberships: Membership[] = [];
+  let pageToken = '';
+  do {
+    const response = await organizationsClient.listMyMemberships({
+      status,
+      pageSize: MAX_PAGE_SIZE,
+      pageToken,
+    });
+    memberships.push(...response.memberships);
+    pageToken = response.nextPageToken;
+  } while (pageToken);
+  return { memberships };
+}
+
 export function OrganizationProvider({ children }: { children: ReactNode }) {
   const { identityId, isClusterAdmin, status: userStatus } = useUserContext();
   const storedContextRef = useRef<StoredContextMode | null>(readStoredContextMode());
@@ -109,25 +128,15 @@ export function OrganizationProvider({ children }: { children: ReactNode }) {
   // Memberships include role/status data used to filter org visibility.
   const membershipsQuery = useQuery({
     queryKey: ['organizations', 'memberships'],
-    queryFn: () =>
-      organizationsClient.listMyMemberships({
-        status: MembershipStatus.ACTIVE,
-        pageSize: MAX_PAGE_SIZE,
-        pageToken: '',
-      }),
+    queryFn: () => listAllMyMemberships(MembershipStatus.ACTIVE),
     enabled: userStatus === 'ready' && Boolean(identityId),
     staleTime: 60 * 1000,
     refetchOnWindowFocus: false,
   });
 
   const pendingMembershipsQuery = useQuery({
     queryKey: ['organizations', 'pendingMemberships'],
-    queryFn: () =>
-      organizationsClient.listMyMemberships({
-        status: MembershipStatus.PENDING,
-        pageSize: MAX_PAGE_SIZE,
-        pageToken: '',
-      }),
+    queryFn: () => listAllMyMemberships(MembershipStatus.PENDING),
     enabled: userStatus === 'ready' && Boolean(identityId),
     staleTime: 60 * 1000,
     refetchOnWindowFocus: false,