[AIEX][NFC] Fix 6 failing lit tests for macOS compatibility and updated codegen#836
Draft
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Draft
[AIEX][NFC] Fix 6 failing lit tests for macOS compatibility and updated codegen#836F-Stuckmann wants to merge 1 commit intoaie-publicfrom
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Conversation
Collaborator
F-Stuckmann
commented
Mar 10, 2026
F-Stuckmann
commented
- Use portable assertion message matching in CHECK lines to work on both macOS and Linux (3 tests)
- Replace bash-specific |& with portable 2>&1 | in RUN lines (2 tests)
- Update expected register assignments in waw_reg_renaming_swpaware to match current SWP-aware allocator output (1 test)
- Use portable assertion message matching in CHECK lines to work on both macOS and Linux (3 tests) - Replace bash-specific |& with portable 2>&1 | in RUN lines (2 tests) - Update expected register assignments in waw_reg_renaming_swpaware to match current SWP-aware allocator output (1 test)
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
F-Stuckmann
commented
Mar 10, 2026
| ; CHECK-NEXT: renamable $x6 = VSHIFT killed renamable $x6, killed renamable $x8, renamable $r4 | ||
| ; CHECK-NEXT: renamable $dm2 = VMAC_f_vmac_bf_vmul_bf_core_X_X killed renamable $dm0, killed renamable $x4, renamable $x11, renamable $r5, implicit-def dead $srfpflags, implicit $crfpmask | ||
| ; CHECK-NEXT: renamable $dm4 = VMAC_f_vmac_bf_vmul_bf_core_X_X killed renamable $dm1, killed renamable $x6, killed renamable $x11, renamable $r5, implicit-def dead $srfpflags, implicit $crfpmask | ||
| ; CHECK-NEXT: $x8, $p2, $dc1 = VLD_2D_x_pseudo_split killed $p2, $m1, $dn1, $dj1, killed $dc1 :: (load (<16 x s32>), addrspace 6) |
Collaborator
Author
There was a problem hiding this comment.
wait why do registers change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.