Skip to content

refactor: remove base_time from mono_clock

1f34bcb
Select commit
Loading
Failed to load commit list.
Draft

refactor: remove base_time from mono_clock #2492

refactor: remove base_time from mono_clock
1f34bcb
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Apr 13, 2026 in 31s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : refactor: remove base_time from mono_clock
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : refactor: remove base_time from mono_clock
    The unix time offset is not used anywhere and was causing issues on windows.
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : The unix time offset is not used anywhere and was causing issues on windows.

Please everyone check, I might have overlooked a "unix time" usage.

Also, I not that the function current_time_monotonic() should probably be removed and the only user seems to be net_crypto. This would remove the extra lock from the windows code path and clean up the code alot.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}