refactor: remove base_time from mono_clock#2492
Draft
Green-Sky wants to merge 1 commit intoTokTok:masterfrom
Draft
refactor: remove base_time from mono_clock#2492Green-Sky wants to merge 1 commit intoTokTok:masterfrom
Green-Sky wants to merge 1 commit intoTokTok:masterfrom
Conversation
Member
Author
|
@iphydf the fuzzer reproducibility never return 0 thingy, how do we properly solve it? |
9fdf727 to
449912f
Compare
|
if you want to remove current_time_monotonic() what would be the replacement for it? |
Member
Author
|
@zoff99 call update on the clock more often. It is supposed to be a caching clock. Side stepping it is kind of wasteful. Especially on windows, where we have to carry around an extra mutex, just for the "sidestepping". |
449912f to
3410fe2
Compare
The unix time offset is not used anywhere and was causing issues on windows.
3410fe2 to
1f34bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unix time offset is not used anywhere and was causing issues on windows.
Please everyone check, I might have overlooked a "unix time" usage.
Also, I not that the function
current_time_monotonic()should probably be removed and the only user seems to be net_crypto. This would remove the extra lock from the windows code path and clean up the code alot.This change is