Add Discord local Discord OAuth setup guide to README - #569
Conversation
There was a problem hiding this comment.
This file was removed recently, it probably means that your branch is not up to date with upstream/main.
There was a problem hiding this comment.
Note that the issue explicitly ask you to edit the Wiki page, not a markdown file in the repo. You can keep the PR open so we can review the changes, but the final work needs to be done on the Wiki page (check the link in the issue).
|
|
||
| ### 4. Update Your `.env` File | ||
|
|
||
| Create or update your `.env` file (in the root or `server/` folder): |
There was a problem hiding this comment.
- This is part of the docs regarding creating the
.env, so "create or update" is not relevant - There is only a single correct place for the
.envfile, it is inserver/.env
| DISCORD_CLIENT_ID=your_client_id_here | ||
| DISCORD_CLIENT_SECRET=your_client_secret_here |
There was a problem hiding this comment.
Please use markdown here.
|
|
||
|  | ||
|
|
||
| ### 2. Configure OAuth2 |
There was a problem hiding this comment.
| ### 2. Configure OAuth2 | |
| ### 2. Configure OAuth2 redirect |
| - Click **Save Changes**. | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Might be worth a short explanation about what is this redirect and why it is important.
Maybe a link to an article or something?
This is relevant for all apps using OAuth and Together is a learning project, so it will be beneficial for everyone reading this wiki.
|
|
||
| ### 3. Retrieve Your Credentials | ||
|
|
||
| - Go to the **General Information** tab. |
There was a problem hiding this comment.
This is not in the General Information tab
|
I think I have added some changes. There should be a READ updates plus two images. @alcpereira |
There was a problem hiding this comment.
This change is not needed
2d5a89b to
cc1638b
Compare
cc1638b to
b65e901
Compare
|
any updates on this @MingJae92? |
|
Sorry, I have been swamped by lots of work. I can hand this over to someone else. |
|
closing this as @dan-foley is taking this one in #567 |
3 participants
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Additionally, please include reasoning if tests have failed.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
npm run testandnpm run test:e2eand all tests have passed successfully or I have included details within my PR on the failure.npm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format