-
Notifications
You must be signed in to change notification settings - Fork 282
fix: add graceful error logging for BaseThread crashes #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aphrodoe
wants to merge
1
commit into
SeedSigner:dev
Choose a base branch
from
aphrodoe:feature/refactor-basethread
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import time | ||
| import logging | ||
| from seedsigner.models.threads import BaseThread | ||
|
|
||
| def test_basethread_crash_handling(caplog): | ||
|
|
||
| # This simulates a background process (like hardware listener or scroll ui) | ||
| # breaking unexpectedly. | ||
| class ExplodingThread(BaseThread): | ||
| def run(self): | ||
| raise ValueError("Intentional Crash!") | ||
|
|
||
| with caplog.at_level(logging.ERROR): | ||
| t = ExplodingThread() | ||
| t.start() | ||
|
|
||
| time.sleep(0.1) | ||
|
|
||
| assert getattr(t, 'keep_running', True) is False | ||
|
|
||
| assert "Thread ExplodingThread crashed: Intentional Crash!" in caplog.text |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought/suggestion that I have is dynamic reassignment of
self.run.Wrapping
run()at runtime viaself.run = wrapped_runcan be a bit fragile and harder to reason about. Would it make sense to instead define a stablerun()inBaseThreadand delegate subclass logic to something like_run_impl()?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is indeed what I was originally intending to do with this PR. However, I realised it would require refactoring across many files. Any class that uses
Basethreadwould have to use_run_impl()instead ofrun(). Since my main goal was bringing light to this, I did not want to do a big refactor. However, if the maintainers think this a viable problem to work on, I can do those changes too. They would just require a rename ofrun()to maybe a simpler name like_run()rather than_run_imp()across few files, and a placeholder definition for it with the same logic I have here.