fix: add graceful error logging for BaseThread crashes#908
Open
aphrodoe wants to merge 1 commit intoSeedSigner:devfrom
Open
fix: add graceful error logging for BaseThread crashes#908aphrodoe wants to merge 1 commit intoSeedSigner:devfrom
aphrodoe wants to merge 1 commit intoSeedSigner:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
Currently, any class that inherits from BaseThread (which handles nearly all hardware listeners, camera loops, and scrolling UI text) can silently crash without yielding any errors or stack traces to the output, refer to issue #907.
Because the underlying loop encapsulates its execution in an isolated boundary, if a developer writes buggy code or an edge-case logic error occurs inside
def run(self):, the thread terminates abruptly. It never halts the main UI/application event loop, but the targeted feature has zero trace output, which might make debugging harder.Solution
By wrapping the subclass's inherited
.run()method in a protective globaltry/except Exception:block at the instance level:logger.exception.self.keep_running = False.Additional Information
MicroPython Portability: Since it natively preserves the
threading.Threadinheritance hierarchy, it stays clean and is cross-compatible if there is MicroPython_threadport in the future.Screenshots
Tried adding an intentional bug in class
HorizontalTextScrollThread, it logs the exception properly. This will help in future dev workflows, rather than making it go unnoticed.This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
Thank you! Please join our Devs' Telegram group to get more involved.
Resolves #907