Skip to content

optimize MongoDbContext.GetDatabaseName #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yileicn merged 3 commits into from
Feb 13, 2026
Merged

optimize MongoDbContext.GetDatabaseName #1294

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ae244
optimize MongoDbContext.GetDatabaseName
yileicn Feb 13, 2026
1107f66
optimize GetDatabaseName
yileicn Feb 13, 2026
fe30cd0
fix(mongo): validate connection string and database name, fail fast o…
yileicn Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 13 additions & 28 deletions src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,39 @@
using BotSharp.Abstraction.Repositories.Settings;
using BotSharp.Abstraction.Utilities;
using System.Threading;

namespace BotSharp.Plugin.MongoStorage;

public class MongoDbContext
{
private const string DefaultTablePrefix = "BotSharp";
private readonly MongoClient _mongoClient;
private readonly string _mongoDbDatabaseName;
private readonly string _collectionPrefix;
private static int _indexesInitialized = 0;

private const string DB_NAME_INDEX = "authSource";

public MongoDbContext(BotSharpDatabaseSettings dbSettings)
{
var mongoDbConnectionString = dbSettings.BotSharpMongoDb;
var mongoDbConnectionString = dbSettings?.BotSharpMongoDb;
if (string.IsNullOrWhiteSpace(mongoDbConnectionString))
throw new InvalidOperationException("MongoDB is enabled but BotSharpMongoDb is not configured.");

_mongoClient = new MongoClient(mongoDbConnectionString);
_mongoDbDatabaseName = GetDatabaseName(mongoDbConnectionString);
_collectionPrefix = dbSettings.TablePrefix.IfNullOrEmptyAs("BotSharp")!;
_collectionPrefix = dbSettings?.TablePrefix.IfNullOrEmptyAs(DefaultTablePrefix)!;
CreateIndexes();
}

private string GetDatabaseName(string mongoDbConnectionString)
{
var databaseName = mongoDbConnectionString.Substring(mongoDbConnectionString.LastIndexOf("/", StringComparison.InvariantCultureIgnoreCase) + 1);

var symbol = "?";
if (databaseName.Contains(symbol))
var mongoUrl = new MongoUrl(mongoDbConnectionString);
var databaseName = mongoUrl.DatabaseName.IfNullOrEmptyAs(mongoUrl.AuthenticationSource);
if (string.IsNullOrWhiteSpace(databaseName))
{
var markIdx = databaseName.IndexOf(symbol, StringComparison.InvariantCultureIgnoreCase);
var db = databaseName.Substring(0, markIdx);
if (!string.IsNullOrWhiteSpace(db))
{
return db;
}

var queryStr = databaseName.Substring(markIdx + 1);
var queries = queryStr.Split("&", StringSplitOptions.RemoveEmptyEntries).Select(x => new
{
Key = x.Split("=")[0],
Value = x.Split("=")[1]
}).ToList();

var source = queries.FirstOrDefault(x => x.Key.IsEqualTo(DB_NAME_INDEX));
if (source != null)
{
databaseName = source.Value;
}
throw new InvalidOperationException(
"MongoDB connection string must specify a database: set the database in the path (e.g. mongodb://host/dbname) or set authSource in the query string (e.g. ?authSource=dbname). ");
}
return databaseName;
return databaseName!;
}

private IMongoDatabase Database => _mongoClient.GetDatabase(_mongoDbDatabaseName);
Expand Down
Loading