optimize MongoDbContext.GetDatabaseName

[yileicn]

Simplify database name extraction using MongoUrl

[qodo-code-review]

Review Summary by Qodo

Simplify database name extraction using MongoUrl

✨ Enhancement

Walkthroughs

Description

• Simplify GetDatabaseName method using MongoUrl class
• Replace manual string parsing with built-in MongoDB URL parsing
• Extract BotSharp constant for reusability
• Remove unused DB_NAME_INDEX constant

Diagram

flowchart LR
  A["Manual String Parsing"] -->|Replace with| B["MongoUrl Class"]
  B -->|Extract| C["DatabaseName Property"]
  C -->|Fallback to| D["AuthenticationSource"]
  D -->|Fallback to| E["BotSharp Constant"]

Loading

File Changes

1. src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs ✨ Enhancement +5/-29

Optimize database name extraction logic

• Refactored GetDatabaseName method to use MongoUrl class instead of manual string parsing
• Added using BotSharp.Abstraction.Utilities import
• Extracted BotSharp as a private constant for reuse
• Removed unused DB_NAME_INDEX constant
• Simplified database name resolution with fallback chain: DatabaseName → AuthenticationSource →
 BotSharp

src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0)

✅ 1. Silent default DB fallback 🐞 Bug ✓ Correctness

Description

GetDatabaseName now falls back to the hard-coded database name BotSharp when both
MongoUrl.DatabaseName and MongoUrl.AuthenticationSource are empty. This can silently send all
Mongo storage reads/writes and collection/index creation to an unintended database, masking
misconfiguration and potentially mixing data.

Code

src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[R26-27]

+        var mongoUrl = new MongoUrl(mongoDbConnectionString);
+        return mongoUrl.DatabaseName.IfNullOrEmptyAs(mongoUrl.AuthenticationSource).IfNullOrEmptyAs(BotSharp)!;

Evidence

The new logic explicitly defaults the database name to BotSharp (instead of returning whatever was
parsed). That derived name is then used to select the IMongoDatabase, and collections are created
if missing—so an unintended DB name affects the entire repository footprint. The settings model and
sample config allow the Mongo connection string to be empty, increasing the chance the fallback path
is hit if MongoRepository is enabled without a fully specified connection string.

src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[24-30]
src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[53-67]
src/Infrastructure/BotSharp.Abstraction/Utilities/StringExtensions.cs[7-11]
src/Infrastructure/BotSharp.Abstraction/Repositories/Settings/BotSharpDatabaseSettings.cs[3-12]
src/WebStarter/appsettings.json[824-831]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`GetDatabaseName` silently falls back to the hard-coded database name `BotSharp` when the MongoDB URL does not contain a database (and no auth source is provided). This can route all MongoRepository reads/writes and collection/index creation into an unintended database.
### Issue Context
`MongoDbContext` uses the derived DB name to build `Database`, and `GetCollectionOrCreate` will create collections in that database. If the DB name fallback is hit, the application can succeed while persisting data to the wrong place.
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[24-30]
- src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[30-67]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

✅ 2. Missing config guardrails 🐞 Bug ⛯ Reliability

Description

MongoDbContext constructs MongoClient and parses the connection string without any local
validation, even though BotSharpMongoDb can be empty by default. Add explicit validation (and a
clear error message) so misconfiguration fails fast and predictably when MongoRepository is enabled.

Code

src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[R15-21]

   public MongoDbContext(BotSharpDatabaseSettings dbSettings)
   {
       var mongoDbConnectionString = dbSettings.BotSharpMongoDb;
       _mongoClient = new MongoClient(mongoDbConnectionString);
       _mongoDbDatabaseName = GetDatabaseName(mongoDbConnectionString);
-        _collectionPrefix = dbSettings.TablePrefix.IfNullOrEmptyAs("BotSharp")!;
+        _collectionPrefix = dbSettings.TablePrefix.IfNullOrEmptyAs(BotSharp)!;
       CreateIndexes();

Evidence

The settings object defaults BotSharpMongoDb to an empty string, and the plugin constructs
MongoDbContext directly from bound settings (no validation). In MongoDbContext, the connection
string is used immediately to build both a MongoClient and a MongoUrl, so a missing/empty value
has no locally enforced guardrails or friendly configuration error.

src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[15-22]
src/Plugins/BotSharp.Plugin.MongoStorage/MongoStoragePlugin.cs[19-57]
src/Infrastructure/BotSharp.Abstraction/Repositories/Settings/BotSharpDatabaseSettings.cs[3-12]
src/WebStarter/appsettings.json[824-831]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
When `Database:Default` is set to MongoRepository, the system constructs `MongoDbContext` even if `BotSharpMongoDb` is empty. There is no local validation or clear configuration error.
### Issue Context
`BotSharpMongoDb` defaults to empty string in settings, and appsettings includes an empty default value. The plugin does not validate before instantiating `MongoDbContext`, and `MongoDbContext` immediately uses the value.
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.MongoStorage/MongoStoragePlugin.cs[19-57]
- src/Plugins/BotSharp.Plugin.MongoStorage/MongoDbContext.cs[15-28]
- src/Infrastructure/BotSharp.Abstraction/Repositories/Settings/BotSharpDatabaseSettings.cs[3-12]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[JackJiang1234]

reviewed